Skip to content

Add ESLint 6 to peerDeps #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Add ESLint 6 to peerDeps #917

merged 1 commit into from
Jul 8, 2019

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jun 28, 2019

No description provided.

@AlMcKinlay
Copy link

Any chance getting this merged? It's kinda getting in our way just now.

@kazupon
Copy link
Member

kazupon commented Jul 8, 2019

Looks good to me.

@mysticatea
Do you have any concerns?

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@michalsnik michalsnik merged commit 6751ff4 into vuejs:master Jul 8, 2019
@vue-bot
Copy link

vue-bot commented Jul 8, 2019

Hey @brettz9, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@xPaw
Copy link

xPaw commented Jul 8, 2019

vuejs/vue-eslint-parser#48 also needs to be merged to fully resolve the compatibility:

warning " > [email protected]" has incorrect peer dependency "eslint@^5.0.0".
warning "eslint-plugin-vue > [email protected]" has incorrect peer dependency "eslint@^5.0.0".

@Kocal
Copy link
Contributor

Kocal commented Jul 16, 2019

Any chance to get a new release? Actually we can't update to ESLint v6 without this PR being released. 😕

Thanks! 😄

@sanscheese
Copy link

This seems to have made it to v5.2.2 but not v5.2.3?

@edmorley
Copy link

edmorley commented Sep 9, 2019

This seems to have made it to v5.2.2 but not v5.2.3?

Any news on this? :-)

scq pushed a commit to totara/eslint-plugin-vue that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants